search

waynegm / imgNotes

Extension of the jQuery imgViewer plugin to add markers and notes to the image
MIT License
99 stars 26 forks source link

Zoom doesn't seem to work properly on touch devices #17

Closed pwcueblocks closed 8 years ago

pwcueblocks commented 8 years ago

When zooming in touch devices, the image weirdly jumps, flickers and when finished zooming the image jumps somewhere else and the same issue persists with demo version also.

waynegm commented 8 years ago

Apologies I haven't found a satisfactory solution for handling touch gestures and mouse together. However, I've updated the Master and demo pages with a more recent version of the underlying imgViewer plugin where I've been trying to improve the touch experience. This should give better response to pinch gestures but is still a bit awkward for dragging.

pwcueblocks commented 8 years ago

Thanks Wayne for looking into this. I have checked it and its seems to be working better now. Looking forward to the finalized version

xjirman commented 8 years ago

hi Wayne! First of all thank you for the plugin, it's exactly what I was looking for! The pinch zoom works great now.

I was wondering if you have an ETA in your mind for nailing the drag gestures on mobile devices?

waynegm commented 8 years ago

Hey I've replaced the code for handling touch gestures in the imgViewer widget with jquery.event.ue.js. This seems to work much better. There are no changes to the external interface for either the imgViewer or imgNotes widget. GitHub master for each widget and the respective demo sites contain the update. If you get a chance give it a try and let me know if its working better for you as well.

xjirman commented 8 years ago

Hi Wayne,

I've updated the libraries to the latest version and it seems to be working well (tested on iPhone6). I'll let you know if something crops up.

Thank you so much for fixing it in such short time! Do you have any "buy me a coffee" button anywhere :)?

Cheers! David

waynegm commented 8 years ago

David, Thanks are enough. I put my code out there for others to use to give back to the community that gave me the Linux OS and other open source software that I run on my main pc.

Wayne