Add an event that indicates that all upload attempts are complete

waynehoover / s3_direct_upload

Direct Upload to Amazon S3 With CORS

MIT License

652 stars 333 forks source link

Add an event that indicates that all upload attempts are complete #241

Open ilyakatz opened 8 years ago

ilyakatz commented 8 years ago

Use case:

User started uploading 2 files
One of the files uploaded successfully
The other upload fails (eg. file size limit exceeded)

With current implementation, s3_upload_failed event is fired but not s3_uploads_complete. So there is no way to know that all attempts to upload have succeeded.

This PR adds s3_uploads_done event that triggers no matter what happened - whether all uploads were succeeded or if they were failures (similar to jqXHR.always)

mcfiredrill commented 8 years ago

Seems reasonable. Any thoughts @waynehoover ? Sorry if you are busy....