waynestate / nova-ckeditor4-field

A Laravel Nova CKEditor4 WYSIWYG Field
MIT License
61 stars 24 forks source link

Security issue detected by ckeditor #95

Closed zsoltjanes closed 4 months ago

zsoltjanes commented 4 months ago

Hi! Can you please take a look about this message,which appeared to me from today on the ckeditor.

image

Hirannuwanpriya commented 4 months ago

I'm also getting the Same Warning.

Hirannuwanpriya commented 4 months ago

For the time being, I added 'versionCheck' => false, to the Nova config file, and the warning has disappeared.

adriandmitroca commented 4 months ago

Adding 'versionCheck' => false to config/nova/ckeditor-field.php didn't work for me. I also don't see any code references to that property.

zsoltjanes commented 4 months ago

Adding 'versionCheck' => false to config/nova/ckeditor-field.php didn't work for me. I also don't see any code references to that property.

Add it to the options section

adriandmitroca commented 4 months ago

Oh nice, thanks!

PieterCappelle commented 4 months ago

Came here for the same issue :-) (thanks for the solution!)

chrispelzer commented 4 months ago

Hey all!

I just released v1.4.0 due to it defaulting the version checking to be false by default. I didn't want to check people who have been using the LTS off guard.

Thanks to @adriandmitroca for the PR. I also added some information to the top of the README.md about what this is and if you wish to get LTS from CKEditor4.

It's out of my hands as all this package is providing the integration with Laravel Nova.

The best thing would be to move to CKEditor5. I've been exploring it in my projects and these days I can't tell the difference between it and CKeditor4 anymore. The thing that I really needed CKEditor4 was the ability to edit source, at the start of CKEditor5 that wasn't the possible.

There is a CKEditor5 package for Laravel Nova at https://github.com/mostafaznv/nova-ckeditor which last was updated 2 months, so they are still going strong with their CKEditor5 package.

haidong2099 commented 3 months ago

in file : Your_Src_Code/config/nova.php Add this config

'ckeditor-field' => [
    'options' => [
        'versionCheck' => false,
    ],
],

];