search

wayneyaoo / alfred-cheat

Manage your self-defined cheat sheets & knowledge base in Alfred
MIT License
138 stars 11 forks source link

Update to Python3 #29

Closed giovannicoppola closed 2 years ago

giovannicoppola commented 2 years ago

Let me know if you see anything out of place!

iliyang commented 2 years ago

Just wanted to express my gratitude for this Python 3 port! I've been missing this workflow. I installed your port and it works like a charm on my M1 Mac running macOS 12.6.

wayneyaoo commented 2 years ago

Hey @giovannicoppola, thank you for the PR! I'm actually impressed that you made changes even to the "dependency" library. I didn't bothering looking at it... Can I get to know that do you think your changes here are general enough for other plugin dev to use? I'm thinking if you can merge those changes back to the original repo https://github.com/deanishe/alfred-workflow/issues/97, though given the vague attitude of the author, I doubt the change will be accepted.

I skimmed through the code and generally it looks good. I don't use macOS a lot these days so @iliyang, thanks for reporting the new version is working. I just have a few comments and it should be ready to merge.

Thank you again!

giovannicoppola commented 2 years ago

The Workflow library is mostly from another user, https://github.com/NorthIsUp/alfred-workflow-py3 and it has worked well for me so far.

wayneyaoo commented 2 years ago

The Workflow library is mostly from another user, https://github.com/NorthIsUp/alfred-workflow-py3 and it has worked well for me so far.

Oh yeah I was monitoring the original issue and this fork looks quite familiar. Thanks for the porting!

giovannicoppola commented 2 years ago

these are just for my reference and will not be included in the release. please feel free to ignore them.

wayneyaoo commented 2 years ago

these are just for my reference and will not be included in the release. please feel free to ignore them.

Um yeah but you committed your personal reference to the repo right?

wayneyaoo commented 2 years ago

these are just for my reference and will not be included in the release. please feel free to ignore them.

Um yeah but you committed your personal reference to the repo right?

ah I see. My bad. that one wasn't in the PR commit..

Thanks! looks good. merged.

wayneyaoo commented 2 years ago

@giovannicoppola your cheatsheet still got merged to the master branch... I'll remove them FYI.