search

waynezsy / pe

0 stars 0 forks source link

Long name in address book will hide insurance details #10

Open waynezsy opened 1 year ago

waynezsy commented 1 year ago

image.png

As per image, i can no longer see insurance for person 2.

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to see very long names

Screenshot 2022-11-11 at 5.07.58 PM.png

Very long names are hidden.

[original: nus-cs2103-AY2223S1/pe-interim#4742] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

Deliberate sabotage as our window is already really long

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The issue I have highlighted in this bug report is not that long names are not fully displayed, but that long names push and hide the insurance details away.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Admittedly, the picture provided to illustrate the issue is extreme since it is not a real name. However, it is illustrative of a real feature flaw, which is that insurance details can become hidden by long names.

The following image makes use of the name of a Sri Lankan cricket player, and we can already see that the insurance box is getting pushed as compared to Jane Doe.

image.png

An even longer name (also a real person) will cause it to disappear:

image.png

Considering the team has implemented wrapping for long phone numbers, it is unclear why wrapping for long names was not implemented to protect the insurance statuses from disappearing. The target user, financial advisors, often have need of their clients' full names. This is why I believe this is a feature flaw that, albeit rare, is legitimate. Hence I have tagged it as severity.Low.

The key here is that it is a flaw that the status box can be pushed in the first place. Even in the most benign of circumstance, if the insurance box can be pushed, this bug is still deserving to be treated as a flaw of VeryLow severity since it is a cosmetic problem caused by a missing functionality. However, when names get longer (which is a distinct possibility since full names may be needed), the ability to use the app becomes compromised.

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: It is a feature flaw that the insurance portion of the person card can be pushed until it disappears by long names, since the developers did not consider or mention this in their UG/DG.

The developers failed to ensure the insurance status cannot be affected by the person's other details. Hence I think this is a missing functionality/product design issue, rather than merely the functionality not working as expected.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: The Insurance portion being able to move and possibly disappear actually affects the functionality in same circumstances, and is not merely cosmetic.