wayoda / LedControl

An Arduino library for MAX7219 and MAX7221 Led display drivers
Other
464 stars 243 forks source link

Unused variable in setChar function #1

Closed wayoda closed 10 years ago

wayoda commented 10 years ago

This issue was was reported by mail :


Hi,

In LedControl::setChar, I think the following is incorrect:

    index=(byte)value;
    if(index >127) {
    //nothing define we use the space char
    value=32;
    }
    v=charTable[index];

Shouldn't it be:

    index=(byte)value;
    if(index >127) {
    //nothing define we use the space char
    index =32;
    }
    v=charTable[index];

Since 'value' is not used anywhere else!

Cheers, Zheng

wayoda commented 10 years ago

An error obviously. Thanks Zheng