ESP8266 compatibility and more characters for setChar()

wayoda / LedControl

An Arduino library for MAX7219 and MAX7221 Led display drivers

Other

464 stars 246 forks source link

ESP8266 compatibility and more characters for setChar() #25

Open harlock974 opened 6 years ago

harlock974 commented 6 years ago

ESP8266

include in case the controller is not an AVR

Character set

The following characters can now be displayed with setChar(): A b c d E F G H i J L n o P r t Y

bertrik commented 6 years ago

This looks like a good fix, except I would simplify the pull request and split it into two parts, so one to fix ESP8266 compilation and another for the character set. This makes it easier for the maintainers to apply and the chance of the pull request getting accepted, e.g. if they agree with one thing but perhaps not with the other.

bertrik commented 6 years ago

Hmm, this project seems dead (no commits in last three years), I'll just create my own fork with these changes and use that.