search

waza-ari / monolog-mysql

MySQL Handler for Monolog, which allows to store log messages to a MySQL Table
MIT License
141 stars 85 forks source link

PHP 8.0 | 8.1 support with tests coverage #45

Closed ybelenko closed 1 year ago

ybelenko commented 1 year ago

Faced really frustrating bug using package(PDO notice about arguments count mismatch) so I spent a day to cover main class(MySQLHandler) with unit tests. I was able to achieve 100% test coverage. Hope it means something.

It's hard to say whether we need extra major tag(3.0.0) at 0b7ca19 for PHP 8.1. Probably 96a2949 should be tagged as 2.0.0 then Composer must resolve appropriate Monolog version.

P.S. still not sure that my own bug has been fixed 🤣 Version installed via Composer command (^1.0.6) has significant differences with latest master.

amacado commented 1 year ago

Hello @ybelenko, your contribution is welcome! I've taken over the maintenance for this project and one main task is to upgrade it for PHP8 compatibility (along with monolog v3). I'm closing this pull request in favor of https://github.com/waza-ari/monolog-mysql/pull/47. If you feel something is missing there please feel free to create a pull request towards https://github.com/waza-ari/monolog-mysql/tree/v2.x.