search

wazuh / qa-system-framework

GNU General Public License v2.0
1 stars 3 forks source link

Adding methods for rules and decoders #73

Closed pro-akim closed 1 year ago

pro-akim commented 1 year ago
Related Issue
#66

Description

This PR includes new methods for adding and replacing rules and decoders.

Evidences

Running:

1. wh.change_decoders('manager1', '/home/akim/Desktop/decoder_total.xml') 2. wh.change_rules('manager1', '/home/akim/Desktop/rules_total.xml') 3. wh.add_decoder('manager1', '/home/akim/Desktop/decoder.xml', '/var/ossec/etc/decoders/local_decoder.xml') 4. wh.add_rule('manager1', '/home/akim/Desktop/rule.xml', '/var/ossec/etc/rules/local_rules.xml')

Results:

1. Changed '/var/ossec/etc/decoders/local_decoder.xml' by '/home/akim/Desktop/decoder.xml' content. 2. Changed '/var/ossec/etc/rules/local_rules.xml' by '/home/akim/Desktop/rules_total.xml' content. 3. Adding a decoder from '/home/akim/Desktop/decoder.xml' to '/var/ossec/etc/decoders/local_decoder.xml' 4. Adding a rule from '/home/akim/Desktop/rule.xml' to '/var/ossec/etc/rules/local_rules.xml'
roronoasins commented 1 year ago

GJ! LGTM

pro-akim commented 1 year ago

06/07/2023

Small changes done around format of f'string use

pro-akim commented 1 year ago

12/07/2023 Update

All changes were done. Add and Change decoders were changed by create decoders Same for rules.

Tests:

Evidences

Running:

1. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_total.xml', '/var/ossec/etc/decoders/local_decoder.xml', overwrite=True) 2. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_simple.xml', '/var/ossec/etc/decoders/local_decoder.xml', overwrite=False) 3. wh.create_rule('manager1', '/home/akim/Desktop/rule_total.xml', '/var/ossec/etc/rules/local_rules.xml', overwrite=True) 4. wh.create_rule('manager1', '/home/akim/Desktop/rule_simple.xml', '/var/ossec/etc/rules/local_rules.xml', overwrite=False)

Results:

1. /var/ossec/etc/decoders/local_decoder.xml changed by /home/akim/Desktop/decoder_total.xml 2. /home/akim/Desktop/decoder_simple.xml added to /var/ossec/etc/decoders/local_decoder.xml 3. /var/ossec/etc/rules/local_rules.xml changed by /home/akim/Desktop/rule_total.xml 4. /home/akim/Desktop/rule_simple.xml added to /var/ossec/etc/rules/local_rules.xml
pro-akim commented 1 year ago

13/07/2023 Update

The linter is not functioning properly. Even though line 891 is not present in https://github.com/wazuh/qa-system-framework/pull/73/commits/72ccf45c34e3e7e43337e04cb1f018ae41ed1402, the linter is still detecting a whitespace error. Therefore, a new pull request will be submitted for review, even if the linting error persists.

pro-akim commented 1 year ago

Update

Fixes done after review. Linting detects multiple spaces after operators in line 900. No multiple spaces were found.

Tests:

Evidences

Running for rules:

1. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_total.xml', '/var/ossec/etc/decoders/local_decoder.xml', overwrite=True) 2. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_simple.xml', '/var/ossec/etc/decoders/local_decoder.xml', overwrite=False) 3. wh.create_rule('manager1', '/home/akim/Desktop/rule_total.xml', '/var/ossec/etc/rules/local_rules.xml', overwrite=True) 4. wh.create_rule('manager1', '/home/akim/Desktop/rule_simple.xml', '/var/ossec/etc/rules/local_rules.xml', overwrite=False) 5. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_total.xml', '/var/ossec/etc/decoders/unexisting_local_decoder.xml', overwrite=True) 6. wh.create_decoder('manager1', '/home/akim/Desktop/decoder_simple.xml', '/var/ossec/etc/decoders/unexisting_local_decoder.xml', overwrite=False) 7. wh.create_rule('manager1', '/home/akim/Desktop/rule_total.xml', '/var/ossec/etc/rules/unexisting_local_rules.xml', overwrite=True) 8. wh.create_rule('manager1', '/home/akim/Desktop/rule_simple.xml', '/var/ossec/etc/rules/unexisting_local_ruleslocal_rules.xml', overwrite=False)

Results:

1. /var/ossec/etc/decoders/local_decoder.xml changed by /home/akim/Desktop/decoder_total.xml 2. /home/akim/Desktop/decoder_simple.xml added to /var/ossec/etc/decoders/local_decoder.xml 3. /var/ossec/etc/rules/local_rules.xml changed by /home/akim/Desktop/rule_total.xml 4. /home/akim/Desktop/rule_simple.xml added to /var/ossec/etc/rules/local_rules.xml 5. /var/ossec/etc/decoders/unexisting_local_decoder.xm does not exist to be overwritten 6. Decoderrs succefully added into a new file named /var/ossec/etc/decoders/unexisting_local_decoder.xm 7. /var/ossec/etc/rules/unexisting_local_ruleslocal_rules.xml does not exist to be overwritten 8. Rules succefully added into a new rule file named /var/ossec/etc/rules/unexisting_local_ruleslocal_rules.xml