wazuh / wazuh-api

Wazuh - RESTful API
https://wazuh.com
GNU General Public License v2.0
69 stars 57 forks source link

Add a "return" statement to this callback. #371

Closed mgmacias95 closed 5 years ago

mgmacias95 commented 5 years ago

Arrays in JavaScript have several methods for filtering, mapping or folding that require a callback. Not having a return statement in such a callback function is most likely a mistake.

This rule applies for the following methods of an array:

Noncompliant Code Example:

var merged = arr.reduce(function(a, b) {
  a.concat(b);
}); // Noncompliant: No return statement

Compliant Solution

var merged = arr.reduce(function(a, b) {
  return a.concat(b);
});

https://github.com/wazuh/wazuh-api/blob/7cd5ef15f668f52324c7f8ebf8677fb1e1106aaf/helpers/filters.js#L152-L155