Desvelao
commented
2 years ago Research
I tried to replicate the reported problem that it states the plugin platform crashed due to the modulesd Wazuh module not working and it causes some API request fails for the statistics job of Wazuh app.
@asteriscos could replicate the problem and we were doing peer to locate and analyze the unhandled promise.
The problem was a supposed logic to build a chain of promises and resolves it with an await. The resolution of the chain of promises was in a try/catch block and it is expected the catch block captures if some promise of the chain was rejected. This is not working as expected due to the method to build the chain of promises was correct.
The try/catch block: https://github.com/wazuh/wazuh-kibana-app/blob/4.3-7.10/server/start/cron-scheduler/scheduler-job.ts#L31-L46
try {
const hosts = await this.getApiObjects();
const data = await hosts.reduce(async (acc: Promise<object[]>, host) => {
const { status } = configuredJobs({ host, jobName: this.jobName })[this.jobName];
if (!status) return acc;
const response = await this.getResponses(host);
const accResolve = await Promise.resolve(acc)
return [
...accResolve,
...response,
];
}, Promise.resolve([]));
!!data.length && await this.saveDocument.save(data, index);
} catch (error) {
ErrorHandler(error, this.logger);
}The supposed chain of promises was generated with Array.prototype.reduce, but the reduce function should return directly a promise to the chain of promises is built correctly and can resolve the chain with the await. Instead of some async actions are done and these are not managed causes an error that the catch could capture.
@asteriscos suggested replacing the chain of promises with running them in parallel because: + it is faster than resolving each one synchronously. + we don't see the requirement to run them synchronously. - it increases the number of requests in an interval of time to the API, affecting to the API request limit.
asteriscos
c-bordon
Description
We have discovered thanks to https://github.com/elastic/kibana/issues/118536 that we have an unhandled promise when a request to the Wazuh API fails because of a connection error. This can make the process crash depending on the configuration of the node.config as stated here https://github.com/elastic/kibana/blob/main/config/node.options#L9
That configuration is disabled by default in opensearch fork.
Steps to reproduce
Expected Result
Actual Result
We need to fix all unhandled promises we find.