wazuh / wazuh-dashboard

Wazuh dashboard, the Wazuh UI platform
https://wazuh.com
Apache License 2.0
22 stars 49 forks source link

Wazuh dashboard's help window has a whitespace between `v` and `version` #225

Closed rauldpm closed 2 hours ago

rauldpm commented 3 days ago

Description

Testing the Step-by-Step deployment in the https://github.com/wazuh/wazuh-dashboard/issues/223 issue, I have found an error in the Wazuh dashboard version's help window

There is an extra whitespace between v and version, which is not present in previous versions

image image

In the pre-4.9.0 versions, this is being modified in

https://github.com/wazuh/wazuh-packages/blob/master/stack/dashboard/base/builder.sh#L140C1-L140C209

sed -i 's|"core.ui.chrome.headerGlobalNav.helpMenuVersion",defaultMessage:"v {version}"|"core.ui.chrome.headerGlobalNav.helpMenuVersion",defaultMessage:"v'${version}'"|' ./src/core/target/public/core.entry.js

Related

Tasks

gdiazlo commented 4 hours ago

To me that looks an unintended change in the sed command which was in charge of setting the version. As the new code does modify it in the forked version, the unintended change disappeared.

gdiazlo commented 2 hours ago

We will use the opensearch style to avoid creating more conflicting changes and possible style problems.