wazuh / wazuh-docker

Wazuh - Docker containers
https://wazuh.com
Other
718 stars 404 forks source link

Remove deprecated attribute `version` in `docker-compose.yml` #1595

Open h3ssan opened 1 month ago

h3ssan commented 1 month ago

Overview

In docker-compose.yml files we used to specify a version attribute, but nowadays is deprecated and no longer used. There's a warning message when using docker-compose.yml file with version attribute specified. Here's the warning message:

$ docker compose ps
WARN[0000] /dev/wazuh-docker/single-node/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion

Official Resources

The official docker documentation said the following about the version attribute.

The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative and you'll receive a warning message that it is obsolete if used.

The Modified Files

What did I modify

I removed the version attribute from both single-node/docker-compose.yml and multi-node/docker-compose.yml files.

vcerenu commented 1 day ago

Hello @h3ssan

I'll be reviewing the PR and I'll let you know if any changes are needed.