davidcr01
commented
1 year ago Update Report
Proposed solution
The proposed solutions intend to modify those curls that fetch files and not modify those that are used with pipes. These last ones have enough checks and parameters to prevent errors.
About the ones that fetch files, the solution can be the parameters of the curl commands to insert the error into the log file.
Two notes here about this:
- The Installation Assistant pretends not to show command error messages, but a friendly output of the result. Because of this, the
curlcommands will not be modified to show the errors in the console prompt. - To contrast this, the errors are sent to the logfile, but as @verdx, the
curlperforms the action silently, without generating the error.
To solve this, new parameters to the curl commands that fetch files will be added:
- Parameter
-f|--fail: (HTTP) Fail fast with no output at all on server errors. This is useful to enable scripts and users to better deal with failed attempts. In normal cases when an HTTP server fails to deliver a document, it returns an HTML document stating so (which often also describes why and more). This flag will prevent curl from outputting that and return error 22. - Parameter
-S|--show-error: When used with[-s, --silent], it makes curl show an error message if it fails.
This info is extracted from the official documentation of the curl command.
It could be great to add the --fail-with-body option, but this was added into the 7.76.0 curl version, and older supported systems of Wazuh could be affected by this parameter.
Early testing
Some testing has been performed to check the behavior of the proposed solution. These tests take into account the two modes of executing the script: with and without the -v|--verbose option that displays the debug messages in the console prompt or not.
Note: the https://raw.githubusercontent.com/wazuh/wazuh/4.6/extensions/elasticsearch/7.x/wazuh-template.json URL does not exists at this moment.
:x: Error case:
davidcr01:~/Wazuh/$ curl -sfSo ./wazuh-template.json https://raw.githubusercontent.com/wazuh/wazuh/4.6/extensions/elasticsearch/7.x/wazuh-template.json >> logfile.txt 2>&1
davidcr01:~/Wazuh/$ cat logfile.txt
curl: (22) The requested URL returned error: 404
davidcr01:~/Wazuh$ cat wazuh-template.json
cat: wazuh-template.json: No existe el archivo o el directorio
davidcr01:~/Wazuh/$ curl -sfSo ./wazuh-template.json https://raw.githubusercontent.com/wazuh/wazuh/4.6/extensions/elasticsearch/7.x/wazuh-template.json 2>&1 | tee -a logfile.txt
curl: (22) The requested URL returned error: 404
davidcr01:~/Wazuh/$ cat logfile.txt
curl: (22) The requested URL returned error: 404
davidcr01:~/Wazuh$ cat wazuh-template.json
cat: wazuh-template.json: No existe el archivo o el directorio
:heavy_check_mark: Success case:
davidcr01:~/Wazuh$ curl -sfSo ./wazuh-template.json https://raw.githubusercontent.com/wazuh/wazuh/4.3/extensions/elasticsearch/7.x/wazuh-template.json >> logfile.txt 2>&1
davidcr01:~/Wazuh$ cat logfile.txt
davidcr01:~/Wazuh$ curl -sfSo ./wazuh-template.json https://raw.githubusercontent.com/wazuh/wazuh/4.3/extensions/elasticsearch/7.x/wazuh-template.json 2>&1 | tee -a logfile.txt
davidcr01:~/Wazuh$ cat logfile.txt :bulb: Notice that the error is displayed only when is generated.
wazuh-install.shThe linux command
curl, used all through the installation assistant, doesn't output progress, errors or any message. When called to use with a pipe that's the intended functioning, but when called with arguments-soto download some file, those messages would be useful. The calls to it normally even have the"${debug}"option, which redirects the nonexistent output to the log file.Example of usage with the two options of variable
debug:Usage with argument
-v: