search

wazuh / wazuh-qa

Wazuh - Quality Assurance
GNU General Public License v2.0
60 stars 30 forks source link

DTT1 - The example dtt1-managers-poc-vagrant.yaml fails running the workflow with multiple threads #5240

Closed mhamra closed 2 days ago

mhamra commented 2 weeks ago
Target version Related issue Related PR/dev branch
4.9.0 4995-dtt1-release

The workflow example file dtt1-managers-poc-vagrant.yaml fails when the workflow_engine is launched with multiple threads (--threads > 1).

The failure occurs because the provision run-manager-tests task doesn't depend on the allocation task. This task must run after all the allocation tasks have finished.

fcaffieri commented 2 weeks ago

This is not a bug, but rather the example versioned for the manager test is not correct. The problem is that the coined example does not have a depends-on that defines the execution criteria of the tasks. When executing 2 tasks with threads, both will be launched in parallel, and in the example it is required that the test task be executed no matter what after the allocation. Having said this, the issue is changed to a task since it is not a bug and the change, which is minimal, will be applied.

rauldpm commented 3 days ago

Moved ETA to 2/5/2024 due to pending review and missing changes

pro-akim commented 2 days ago

Review Notes

LGTM

rauldpm commented 2 days ago

LGTM