wazum / sluggi

The TYPO3 CMS slug helper
GNU General Public License v3.0
38 stars 22 forks source link

Unable to save folder with exclude_page_types=254 (folder) #103

Closed christophlehmann closed 7 months ago

christophlehmann commented 8 months ago

in TYPO3 12.4.8 with sluggi 12.0.2 I get an Exception when i save a folder

Bildschirmfoto 2023-11-21 um 22 21 40

When i remove 254 from exclude_page_types setting, then I don't get the exception.

The function in typo3/cms-redirects looks like this

Bildschirmfoto 2023-11-21 um 22 26 32

Little possibly bad smell here:$persistedChangedItem might be null, but in line 88 this is not checked.

christophlehmann commented 8 months ago

The same Exception occurs, when one de/activates a page via context menu of page tree

wazum commented 7 months ago

Thank you for the report. I can reproduce it with this latest version of TYPO3 CMS (it works with earlier versions). I need to take a look at how to solve this.

christophlehmann commented 7 months ago

It does not occur any more with todays release TYPO3 v12.4.9. Might be that commit which fixed it.

devtroll commented 7 months ago

Fix for TYPO3 v11?