search

wb666greene / AI-Person-Detector

Python Ai "person detector" using Coral TPU or Movidius NCS/NCS2
17 stars 4 forks source link

Thanks for commenting extensivly #6

Open ozett opened 4 years ago

ozett commented 4 years ago

👏

often and normally all "issues" are only bug-reports about errors,errors,erros. this one is a congratulation.

i am more than glad about your extensive and explanatory comments in the code. thanks!

(i was thinking about adopting some parts of your code, maybe a first the zoom on detection-boxes and than i was wondering how i could check multi-detection-region against polygon-areas in node-red. and i only saw a single-bounding-box coming back from detection via mqtt. but deep in the code-comments i found explained the reason:

break # one person detection is enough here

i am really glad i found the explanation and now i can go on thinking how to adopt some good designed parts. thanks again)

wb666greene commented 4 years ago

You're welcome. Multiple detections complicate things, the highest confidence seems to be the one to pay the most attention to.

On Fri, Jun 26, 2020 at 1:36 PM toz notifications@github.com wrote:

👏

often and normally all "issues" are only bug-reports about errors,errors,erros. this one is a congratulation.

i am more than glad about your extensive and explanatory comments in the code. thanks!

(i was thinking about adopting some parts of your code, maybe a first the zoom on detection-boxes and than i was wondering how i could check multi-detection-region against polycon-areas in node-red. and i only saw a single-bounding-box coming back from detection via mqtt. but deep in the code-comments i found explained the reason:

break # one person detection is enough here https://github.com/wb666greene/AI-Person-Detector/blob/master/Coral_TPU_Thread.py#L88

i am really glad i found the explanation and now i can go on thinking how to adopt some good designed parts. thanks again)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wb666greene/AI-Person-Detector/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHQHWJV4HCNFLCCG3MXHOTLRYTTD3ANCNFSM4OJSHIYA .