search

wbailey / command_line_reporter

A gem for making it easy to produce a report while a ruby script is executing
Apache License 2.0
432 stars 23 forks source link

Fix for Newrelic_rpm incompatibility #14

Closed pnock closed 9 years ago

pnock commented 10 years ago

Rake tasks with newrelic_rpm in the gemset fail because newrelic sets formatter= to a Proc. This is a quick fix to pass through format types that aren't Strings.

pnock commented 10 years ago

Ugh. Hound complains about my syntax when I was following your style, which is a little annoying.

Not sure why my test fails, I'll look at it later. Having problems with charlock_holmes so I can't run tests locally. The test seemed pretty innocuous, not entirely sure why it's failing.

wbailey commented 10 years ago

Hound is annoying. I will always prefer single quotes to double when there isn't any interpolation to be done.

pnock commented 10 years ago

Ok, think I got it this time :-)

Part of me doesn't quite like how this smells though - it seems a bit hacky to essentially special case for the newrelic gem, when there's no particular reason the newrelic gem needs to be loaded for my batch reporting jobs, except that it's painful not to...