Closed iurifq closed 7 years ago
Thanks @iurifq! Just wanted to check that you did a sanity check by running all of the examples? Do they have the same output as the current version of the CLR?
If you mean the test suite, yeah all tests pass. :+1:
I honestly didn't check the wiki examples though
Can you run through the wiki examples in your fork and make sure they are comparable. I know that is not standard but I have used it as another visual sanity test in the past to ensure everything is working as expected.
Hey @wbailey I've copied most of the wiki examples to a file and "diffed" the output of the fork with the original gem. The only differences were in the random generated examples and in the dates. So, everything is working \o/. You can check the file here https://gist.github.com/iurifq/a7ce4729be3a7625ba7f
ping!
Given my suggestions, do you want me to just close this PR and then you can submit a new one?
Maybe this is coming out of the blue, but I had the need to support more than 3 colors in a table. Ansi gem approximates rgb colors to the colors supported by the terminal. I replaced the colored gem with Ansi and added the
color_code
option. Please review with :heart:I didn't want to change anything else, but maybe a next step would be to move all color related things to one place. What do you think?