search

wbailey / command_line_reporter

A gem for making it easy to produce a report while a ruby script is executing
Apache License 2.0
432 stars 23 forks source link

.ruby-version should not be in version control #31

Closed leoarnold closed 6 months ago

leoarnold commented 7 years ago

The file .ruby-version should not be checked into your Git repo. It might cause Travis CI to run all your commands with the Ruby version specified in .ruby-version and therefore ignoring the versions you specified in .travis.yml.

For more information, see the recommended .gitignore file, especially the section

# for a library or gem, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# Gemfile.lock
# .ruby-version
# .ruby-gemset
pboling commented 6 months ago

This recommendation is fully out of date. All the version locks should be in source control. Bundler / Rubygems changed the recommendation a few years ago.

This issue should be closed, and if it isn't already, the Gemfile.lock shoudl be un-ignored.

leoarnold commented 6 months ago

I don't agree. But then again, this issue is 7 years old and I don't even remember it or the gem, so whatever.