search

wbailey / command_line_reporter

A gem for making it easy to produce a report while a ruby script is executing
Apache License 2.0
432 stars 23 forks source link

reduce clutter of $: #6

Closed maxmeyer closed 12 years ago

maxmeyer commented 12 years ago

Hi Wes,

thank you very much for your gem. While working with it I found, that you doesn't use a subdirectory for your library below lib.

Following the suggestions in http://weblog.rubyonrails.org/2009/9/1/gem-packaging-best-practices/ it's the best to use the following structure lib/command_line_reporter/<files>. Otherwise you clutter $: and may overwrite existing libraries.

Along with the relocation of the files I took the freedom and place all require-calls at "central" places and deleted all File.join-calls, using equivalent require(_relevative)-calls.

After all I did a full run of rspec which passes with no errors. I'm using ruby 1.9.3.

I'm happy to hear your feedback.

Cheers, MaxMeyer