search

wbaldoumas / markdown-colorcode

An extension for Markdig that adds syntax highlighting to code through the power of ColorCode-Universal.
https://wbaldoumas.github.io/markdown-colorcode/
MIT License
28 stars 5 forks source link

support netstandard 2.0 #149

Closed ElderJames closed 3 months ago

ElderJames commented 3 months ago

I want to use markdig and this extensions in Source Generators.

wbaldoumas commented 3 months ago

Thanks for opening up this issue, @ElderJames.

Unfortunately CsharpToColouredHTML, which this library depends on, does not support .NET Standard 2.0. Support for .NET Standard 2.0 will need to be added there first before making these updates to Markdown.ColorCode.

wbaldoumas commented 3 months ago

@ElderJames unfortunately the pull request that was just merged won't allow for the Markdown.ColorCode.CSharpToColoredHtml package to be built.

Although you only targeted Markdown.ColorCode with your .NET Standard 2.0 TFM update, Markdown.ColorCode.CSharpToColoredHtml depends on the main package and will not build with that update in place. For now, I'm reopening this issue and reverting your change.

Please open an issue in the CsharpToColouredHTML repository regarding .NET Standard 2.0 support so we can get this change pushed through for both Markdown.ColorCode and Markdown.ColorCode.CSharpToColoredHtml if you still need it.

ElderJames commented 3 months ago

What's the issue with Markdown.ColorCode.CSharpToColoredHtml? It build successfully on my locale PC.

wbaldoumas commented 3 months ago

What's the issue with Markdown.ColorCode.CSharpToColoredHtml? It build successfully on my locale PC.

You're right. I opened https://github.com/wbaldoumas/markdown-colorcode/pull/152 to reintroduce your changes but also bump the version number to trigger a release. Thanks for the patience on this one - totally my bad regarding the build issue. 🤦‍♀️