wballard / starphleet

19 stars 37 forks source link

Fix chatty and misleading error logging related to secrets #374

Closed shawnrushefsky closed 5 years ago

shawnrushefsky commented 5 years ago

The Problem: secrets only needs to be executed inside the container, and only exists in the container for that reason. However, the ship accesses those orders files in a bunch of different places, and logs errors related to secrets not existing.

The Solution: In the 5 files where the ship slurps the orders files, I provided no-op functions that override secrets and fromJson in that specific context.