Closed mikemartin1090 closed 5 years ago
@datfinesoul This is mostly your code so I wanted to tag you and get your feedback on the code review comments.
After convo in deploycache chat on Teams, I guess I'll make these changes in glg/starphleet for now, in the fdt
branch there.
Re-creating and testing these changes in glg/starphleet#2 per conversation in Teams.
https://github.com/glg/starphleet/pull/4 replaces this PR
This PR is based on the work that @datfinesoul and @ddai1 completed here in this ZenHub ticket. The only difference IS that we want to merge these changes against the azure-xenial branch. NOT the asg branch since we are applying these to devships first.