While deploying a new services ship, I've come across an issue where the orders files of some services (aws dev creds china and notify) are unsetting our AWS_REGION via the run_orders function. You'd think in the case of notify, since the region is set in the secret, it would thus pull the value from secrets. However, in run_orders we stub out the secrets function, thus setting the AWS_REGION to null. Same situation in the case of aws-dev-creds-china...
This fix makes us explicitly use the region in the AWS CLI command, as that trumps any other environment or profile settings (according to the docs). I noticed this issue while 'pulling' containers, but have preemptively patched the push as well.
While deploying a new services ship, I've come across an issue where the orders files of some services (aws dev creds china and notify) are unsetting our AWS_REGION via the run_orders function. You'd think in the case of notify, since the region is set in the secret, it would thus pull the value from secrets. However, in run_orders we stub out the secrets function, thus setting the AWS_REGION to
null. Same situation in the case of aws-dev-creds-china...This fix makes us explicitly use the region in the AWS CLI command, as that trumps any other environment or profile settings (according to the docs). I noticed this issue while 'pulling' containers, but have preemptively patched the push as well.