I need to add tests for the KafkaAdmin changes I made:
1639
1640
1641
1642
1643
1645
I didn't have time yet to do tests... Given that the existing KafkaAdminClient code currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.
Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.
And then after that tackle the tests/missing coverage.
But creating this and assigning it to myself so that I don't forget
I need to add tests for the KafkaAdmin changes I made:
1639
1640
1641
1642
1643
1645
I didn't have time yet to do tests... Given that the existing
KafkaAdminClientcode currently on the master branch is broken, sometimes in subtle ways, I decided fine to put them up as-is since then the code will be mostly working, and then later add tests to prevent regressions.Frankly, the test fixtures are a bit of a mess, so I will probably instead go the route of finishing #1193, as that will both simplify the code drastically and require a few fixture changes.
And then after that tackle the tests/missing coverage.
But creating this and assigning it to myself so that I don't forget