search

wbarnha / kafka-python-ng

Fork for Python client for Apache Kafka
https://wbarnha.github.io/kafka-python-ng/
Apache License 2.0
78 stars 11 forks source link

Should pickling be re-enabled? #116

Open wbarnha opened 8 months ago

wbarnha commented 8 months ago

https://github.com/dpkp/kafka-python/commit/9740b2b88b41726f143b3367285dbc118bfa0a8a added pickling support.

However, in https://github.com/dpkp/kafka-python/pull/899/files#diff-ec0c29b3ee77321d4150e7578616a894L9, I removed the import, as it appeared to be unused. As a result, the entire file https://github.com/dpkp/kafka-python/commit/9740b2b88b41726f143b3367285dbc118bfa0a8a#diff-74e9dcafb2f9d7443ee297bb5aab1c32 is never used.

So either the import needs to be added back, or the entire file kafka/protocol/pickle.py should be removed.

I haven't spend the time to research how all this works... @dpkp does importing pickle have some silent side-effect that fixes pickling?