search

wbarnha / kafka-python-ng

Fork for Python client for Apache Kafka
https://wbarnha.github.io/kafka-python-ng/
Apache License 2.0
67 stars 8 forks source link

Remove all vendoring #169

Closed s-t-e-v-e-n-k closed 6 months ago

s-t-e-v-e-n-k commented 6 months ago

With this project removing support for Python 2 as well as any version of Python 3 that is < 3.8, utilise pyupgrade to bring this project to that level of Python 3 code, as well as removing all vestiges of vendored backports.

wbarnha commented 6 months ago

I coincidentally ran pyupgrade in https://github.com/wbarnha/kafka-python-ng/pull/171 but I'll go ahead and review this to see what I missed.

s-t-e-v-e-n-k commented 6 months ago

I'm braced and ready for doing the rebase. :-)

wbarnha commented 6 months ago

I'm braced and ready for doing the rebase. :-)

You responded as I was opening this PR. This is going to be a chunky one to rebase, I'll get around to merging it tomorrow

s-t-e-v-e-n-k commented 6 months ago

Yeah, I suspect it is going to be easier to carry over the vendor removal bits I want, and drop every other change. I can probably sort that out in the next 30 minutes if you wish.

wbarnha commented 6 months ago

Yeah, I suspect it is going to be easier to carry over the vendor removal bits I want, and drop every other change. I can probably sort that out in the next 30 minutes if you wish.

If you could, that would be great! I'm pretty eager to get this merged.

s-t-e-v-e-n-k commented 6 months ago

Forced pushed, let's see if I missed anything. I'm not 100% happy with the crimes I committed in benchmarks/variant_speed.py, but I also didn't want to completely rewrite it to remove its reliance on the Python 2 construct of int2byte.