search

wbent22 / reviewing-a-pull-request

https://lab.github.com/githubtraining/reviewing-pull-requests
MIT License
0 stars 0 forks source link

change title on README #4

Closed wbent22 closed 3 years ago

wbent22 commented 3 years ago

I left reviews, I opened a file and committed it, and opened a pull request

github-learning-lab[bot] commented 3 years ago

Good pull requests help contributors understand the context. They have a body description detailing the suggested change.

Let's edit this pull request to add a body description.

:keyboard: Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click octicon-kebab-horizontal in the top right corner of the comment box to make an edit.
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have:
    • Left reviews and line comments
    • Created a file and made a commit
    • Opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done.

If you would like help troubleshooting, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.

Watch below for my response

github-learning-lab[bot] commented 3 years ago

Congratulations! :tada:

hulatocat

Nice work helping me with all these pull requests! As you continue working on GitHub, remember that high quality reviews improve your projects. If you are new to a repository, inquire about what review practices they have so you can hit the ground running.