wbolster / emacs-evil-colemak-basics

Emacs package with basic key rebindings for evil-mode with the Colemak keyboard layout
86 stars 23 forks source link

Add visual-state bindings for changing case and other minor fixes #11

Closed timacs closed 3 years ago

timacs commented 3 years ago

Hello, Wouter!

Could you please review this PR? Most of these changes are rather straightforward, and I've tried to explain the non-trivial changes in commit messages.

wbolster commented 3 years ago

thanks, i agree with all of these.

i wasn't aware that vim has lowercase/uppercase commands in visual mode (i usually use gu and gU even in visual mode). your rationale for choosing l/L in colemak totally fits the design rationale of this package, so 👍🏼