search

wbolster / nothing-to-say

gnome shell extension to only unmute the microphone when you have something to say
GNU General Public License v2.0
247 stars 22 forks source link

Play sounds when muting and unmuting #37

Closed BenignBeppe closed 2 years ago

BenignBeppe commented 3 years ago

Added playing two different sounds when muting and unmuting to complement visual feedback. Includes setting to turn this on or off.

wbolster commented 3 years ago

sorry for not paying attention to this for a long time.

this pr is now outdated, and had conflicting files.

iuridiniz commented 2 years ago

I want this feature. I'm not the original author, but I think I can continue it. Could I ?

wbolster commented 2 years ago

that depends on @BenignBeppe :)

BenignBeppe commented 2 years ago

Yes, feel free to work on this if you want to. I haven't really looked at the merge yet.

BenignBeppe commented 2 years ago

I finally got around to look at this. The rebase wasn't that bad, but I ran into an issue with different functions for Gnome 3 and 4. I added some logic that should be compatible for both versions, though I could only test on 3.36.9 which is what I have.

BenignBeppe commented 2 years ago

Thanks for testing on Gnome 41, @szpak. I hope the patches fix the settings crash. I'll have to look into why sound only play once. Maybe something with the rewind not working anymore on newer Gnome.

BenignBeppe commented 2 years ago

I found another way to rewind the sound before playing. Can you try if this works?

szpak commented 2 years ago

I found another way to rewind the sound before playing. Can you try if this works?

It works fine with 41 (both sounds and preferences), nice!

There is just one warning in the logs:

gjs[23110]: JS WARNING: [/home/foobar/.local/share/gnome-shell/extensions/nothing-to-say@extensions.gnome.wouter.bolsterl.ee/prefs.js 47]: Too many arguments to method Gtk.ListBox.append: expected 1, got 2

BenignBeppe commented 2 years ago

Realised I didn't add a comment for this. The warning should be gone now. I tried to do the pushing the way git told me to and it resulted in a lot of duplicated commits. The changes should still be good though and a squash merge should clean it up. Still haven't gotten the hang of the Github review process :/

wbolster commented 2 years ago

thanks all! just published a new version including these changes

wbolster commented 2 years ago

the .zip uploaded to the extension website was missing the sound files 🙉

fixed via 5b6f3a14ba44b277793b3e17ea5580d01628fcc3; uploaded a new version already

BenignBeppe commented 2 years ago

Good, I didn't notice this until I was on a different machine🙂