search

wbolster / nothing-to-say

gnome shell extension to only unmute the microphone when you have something to say
GNU General Public License v2.0
249 stars 23 forks source link

Do not fail completely on missing GStreamer #53

Closed szpak closed 2 years ago

szpak commented 2 years ago

If optional sound dependencies are not available, just print warning and skip the sound part instead of failing completely.

It would prevent #47 and #52.

Btw, I am not a JavaScript developer. Feel free to fix naming convention or lame constructions. Btw2, the warning in preferences could be "got prettier":

image

wbolster commented 2 years ago

@BenignBeppe wdyt?

szpak commented 2 years ago

This is definitely good to have. It would be even better if GStreamer could be added through dependencies, but I don't know if/how it possible with Gnome extensions.

It could be applied for RPM/DEB with the extension, but I also haven't seen that mechanism for ZIP extensions downloaded from the "portal".

wbolster commented 2 years ago

lgtm after a cursory glance, but i'd like @BenignBeppe to have the final say since they looked before in more detail. please have a look again @BenignBeppe if you have time 🙏🏼

BenignBeppe commented 2 years ago

Looks good except there is still an issue with warning being shown when it shouldn't with Gnome shell 3.36.9 (and wrap function causes an error).