search

wbolster / nothing-to-say

gnome shell extension to only unmute the microphone when you have something to say
GNU General Public License v2.0
250 stars 23 forks source link

v16? #58

Closed brianjmurrell closed 2 years ago

brianjmurrell commented 2 years ago

https://extensions.gnome.org/local/ just updated me to v16 but that tag doesn't seem to exist here.

wbolster commented 2 years ago

the version number is not assigned by me, but by ‘SweetTooth’ which i guess is some automation behind the https://extensions.gnome.org/ website. the metadata.json looks like this (note the _generated field) after installation, while the metadata.json in this repo doesn't even have a version field:

{
  "_generated": "Generated by SweetTooth, do not edit",
  "description": "Unmute the microphone only when you have something to say.\n\nthis gnome-shell extension always keeps your microphone muted, unless you actually have something to say.\n\ntl;dr:\n\nmicrophone icon in the top bar, only visible when recording is active\none-click mute/unmute using the icon\nkeyboard shortcut to mute/unmute, with push-to-talk\nosd and sound notifications for microphone events\n\nDO NOT REPORT ISSUES HERE. USE GITHUB",
  "name": "Nothing to say",
  "settings-schema": "org.gnome.shell.extensions.nothing-to-say",
  "shell-version": [
    "40",
    "41",
    "42",
    "3.36.9"
  ],
  "url": "https://github.com/wbolster/nothing-to-say",
  "uuid": "nothing-to-say@extensions.gnome.wouter.bolsterl.ee",
  "version": 16
}

so i'm not sure what to do here. i can tag after the fact, which i just did (v16), but it's not ideal at all since uploading is a manual process.

wbolster commented 2 years ago

to be clear: i uploaded a new version earlier today so the update is legit

brianjmurrell commented 2 years ago

I can tag after the fact, which i just did (v16),

That is fine.

but it's not ideal at all since uploading is a manual process

But even the manual upload really ought to be done from a tag (so after tagging) after checking out that tag. Just to keep the process checked-and-balanced.

Tagging after the fact is fine, as long as you tag before anything else lands to the branch.

wbolster commented 2 years ago

this repo is not that active 🙃 i simply uploaded (and tagged) the main branch

wbolster commented 2 years ago

and the problem is that the version number is only known after uploading and after approval (which can take a while)

and since the tag contains that version number, it cannot be done up front

wbolster commented 2 years ago

fwiw, i just pushed ebe1937905b9d464870458584006ebb288555cbb so that i can at least see what i uploaded