search

wbolster / nothing-to-say

gnome shell extension to only unmute the microphone when you have something to say
GNU General Public License v2.0
247 stars 22 forks source link

use modern import/subclass style for signals #69

Closed wbolster closed 11 months ago

wbolster commented 11 months ago

follow-up to #68

wbolster commented 11 months ago

this was missing from #68, and flagged during review after uploading to extensions.gnome.org // cc @axxapy

axxapy commented 11 months ago

Nice to know! I actually was looking into it since there was nothing in the documentation (or I missed it), I checked gnome's own source code and noticed they still use old way for signals together with new imports, so I decided it's okay:

Now, when I know the proper solution, I can see other places where they use the new way: image

Should've done deeper investigation. Thanks for addressing it!

wbolster commented 11 months ago

no worries, it was a quick fix and the reviewer pointed me in the right direction.

your PR was fantastic and would've cost me ages to do myself, since i am not hands-on at all (anymore) in the gnome ecosystem.