wbolster / plyvel

Plyvel, a fast and feature-rich Python interface to LevelDB
https://plyvel.readthedocs.io/
Other
530 stars 75 forks source link

pip install plyvel not working on Windows platform #60

Open josephernest opened 6 years ago

josephernest commented 6 years ago

Are there no binaries for Python 2.7 - Windows? Currently

pip install plyvel 

produces installation error on Python 2.7 - Windows if you don't have the right compiler installed.

Thanks in advance.

wbolster commented 6 years ago

there are no binaries (wheels) at all on pypi. and i have not used windows in 15 years so i'm afraid i cannot help you with that.

josephernest commented 6 years ago

Thank you for your answer @wbolster. Is plyvel the "official" LevelDB for Python 2.7, or is there another implementation ready-to-use for Linux, Mac, Windows? (including binaries)

wbolster commented 6 years ago

not that i am aware of. plyvel is (or at least was) the fastest and most feature complete leveldb library for python.

would be an idea for you to provide a windows build in the form of a .whl package? i can publish it on pypi.

wbolster commented 6 years ago

plyvel 1.0.1 is on pypi, with binary linux packages! please give it a try!

https://plyvel.readthedocs.io/en/latest/news.html#plyvel-1-0-1

https://twitter.com/wbolster/status/949394305893924865

wbolster commented 6 years ago

if you have experience with making builds for windows using https://www.appveyor.com/ i would be more than happy to bless these as official and submit them to pypi. (update: actually no:https://github.com/wbolster/plyvel/issues/60#issuecomment-731589317)

however, i have neither time, skill, nor interest to accomplish this myself.

metatsmith commented 6 years ago

I believe the problem here is that the C Standard Library headers have become platform dependent. I'm also running into this same problem, and I've looked around the web a bit after a lot of frustration (which I imagine @josephernest is also feeling. The potential solution I am testing right now is to install the windows SDK kit for my system. I have windows 7, so I'm using the windows 7 SDK.

This article leads me to believe this should work: https://social.msdn.microsoft.com/Forums/vstudio/en-US/cfa48739-cd32-43d2-9d27-2b6653da6645/canf-find-standard-c-header-file-in-visual-studio-2015-community-version?forum=vclanguage

Windows7 SDK : https://www.microsoft.com/en-us/download/details.aspx?id=3138 Windows10 SDK: https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk

I'll post a follow up after I do some experimentation.

wbolster commented 6 years ago

see also #70, perhaps it helps

wbolster commented 6 years ago

@bauerj https://github.com/wbolster/plyvel/issues/60#issuecomment-355781054

i see you are working on this? https://github.com/bauerj/plyvel/commit/5acbdea5f77413283fcf4f714b61b4f56102b2b6

bauerj commented 6 years ago

Yes, well, I'm trying: https://ci.appveyor.com/project/bauerj/plyvel/build/job/rpfrwrjvoj26ffjf

The current issue is that Microsoft does not supply stdint.h with their SDK (although it seems to be part of the C standard).

This could be solved by adding the header file to this project. What do you think about doing that?

Or maybe the library can be changed to not use that file. As far as I can see it only uses uint64_t from there. I'm a C noob but maybe unsigned long long could be used instead?

vaskomitanov commented 6 years ago

Few months ago I needed windows build of the latest LevelDB and I worked a little bit to have usable windows build. Here is the link in case you may find it useful for above problems: https://github.com/vaskomitanov/leveldb

ofek commented 5 years ago

Any progress on this? Many of us Windows users would greatly appreciate binary wheels πŸ™

wbolster commented 5 years ago

i am not working on this myself. if anyone gets automatic builds working on appveyor on (a fork of) this repo, i would be happy to merge it

Myriad-Dreamin commented 5 years ago

Few months ago I needed windows build of the latest LevelDB and I worked a little bit to have usable windows build. Here is the link in case you may find it useful for above problems: https://github.com/vaskomitanov/leveldb

tx. i created a lib with vs2017, then modified the setup.py,like that

Extension(
        ...
        libraries=['leveldb vaskomitanov-r x64',
                   'libboost_chrono-vc141-mt-x64-1_69',
                   'libboost_date_time-vc141-mt-x64-1_69',
                   'libboost_filesystem-vc141-mt-x64-1_69',
                   'libboost_system-vc141-mt-x64-1_69',
                   'libboost_thread-vc141-mt-x64-1_69'],
        ...
    )

finally my plyvel was installed.

renkexinmay commented 5 years ago

Few months ago I needed windows build of the latest LevelDB and I worked a little bit to have usable windows build. Here is the link in case you may find it useful for above problems: https://github.com/vaskomitanov/leveldb

tx. i created a lib with vs2017, then modified the setup.py,like that

Extension(
      ...
      libraries=['leveldb vaskomitanov-r x64',
                 'libboost_chrono-vc141-mt-x64-1_69',
                 'libboost_date_time-vc141-mt-x64-1_69',
                 'libboost_filesystem-vc141-mt-x64-1_69',
                 'libboost_system-vc141-mt-x64-1_69',
                 'libboost_thread-vc141-mt-x64-1_69'],
      ...
    )

finally my plyvel was installed.

@Myriad-Dreamin Could you give some more details about creating the lib? which set.py did you modify? I'm new to vs, and I'm suffering from the same plyvel installation problem. Thank you a lot!

UPD: solved! for people who may need help: compile boost.lib and LevelDB.lib using VS, you'll see how to reach this step following a tutorial for it.

xyqyear commented 5 years ago

It seems like the latest release of leveldb (1.21) added native support for Windows. Would you consider to figure this out and add this support also for plyvel? I also don't know how to compile a program on windows, so I cannot offer help. (I'm from China, so sorry for my poor English) Thanks very much!

wbolster commented 5 years ago

i do not use windows. https://github.com/wbolster/plyvel/issues/60#issuecomment-445578463

namuyan commented 5 years ago

https://gist.github.com/namuyan/1a8aef3482fa17c6b206ff028efc9807 I wrote how to install on winodws, how about MSYS2? but this way require window. Many people will find it helpful to install with PIP, I think.

ppolxda commented 5 years ago

i see. i not has pypi account, you can try to build you self if you want to build in windows

  1. install Visual Studio 2017
  2. install https://github.com/Microsoft/vcpkg 3.vcpkg install leveldb "vcpkg install leveldb:x64-windows" 4.install cython, "pip3 install cython" 5.build cpp file,"cython --cplus --fast-fail --annotate plyvel/_plyvel.pyx" 6.build pxd and include leveldb, "python setup.py build_ext --include-dirs=%VCPKG_PATH%/%VCPKG_SYS_PATH%/include --library-dirs=%VCPKG_PATH%/%VCPKG_SYS_PATH%/lib --libraries=shlwapi" 7.install package or build wheel,"python setup.py install" or "python setup.py bdist_wheel"
  3. finish

namuyang notifications@github.com 于2019εΉ΄4月22ζ—₯周一 δΈ‹εˆ2:09写道

https://gist.github.com/namuyan/1a8aef3482fa17c6b206ff028efc9807 I wrote how to install on winodws, how about MSYS2?

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wbolster/plyvel/issues/60#issuecomment-485335817, or mute the thread https://github.com/notifications/unsubscribe-auth/AEUBLPHQI6XOMSMXUEV5GTLPRVJDJANCNFSM4EDJIN4A .

Ovyerus commented 5 years ago

Personally using binary/wheel provided by #98 and they seem to be working fine.

ppolxda commented 4 years ago

update new appveyor.yml. https://gist.github.com/ppolxda/1ebc6bdd2053984bc5ff7a799647bf75 windows wheel release https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win appveyor test build https://ci.appveyor.com/project/ppolxda/plyvel

crb912 commented 4 years ago

update new appveyor.yml. https://gist.github.com/ppolxda/1ebc6bdd2053984bc5ff7a799647bf75 windows wheel release https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win appveyor test build https://ci.appveyor.com/project/ppolxda/plyvel

Seems not work, I test with plyvel-1.1.0-cp36-cp36m-win_amd64.whl

Error:

  File "plyvel\_plyvel.pyx", line 356, in plyvel._plyvel.DB.__iter__
  File "plyvel\_plyvel.pyx", line 362, in plyvel._plyvel.DB.iterator
  File "plyvel\_plyvel.pyx", line 788, in plyvel._plyvel.Iterator.__init__
  File "plyvel\_plyvel.pyx", line 91, in plyvel._plyvel.raise_for_status
plyvel._plyvel.CorruptionError: b'Corruption: corrupted compressed block contents'
wbolster commented 4 years ago
b'Corruption: corrupted compressed block contents

that may be due to a missing libsnappy

ppolxda commented 4 years ago

update new appveyor.yml. https://gist.github.com/ppolxda/1ebc6bdd2053984bc5ff7a799647bf75 windows wheel release https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win appveyor test build https://ci.appveyor.com/project/ppolxda/plyvel

Seems not work, I test with plyvel-1.1.0-cp36-cp36m-win_amd64.whl

Error:

  File "plyvel\_plyvel.pyx", line 356, in plyvel._plyvel.DB.__iter__
  File "plyvel\_plyvel.pyx", line 362, in plyvel._plyvel.DB.iterator
  File "plyvel\_plyvel.pyx", line 788, in plyvel._plyvel.Iterator.__init__
  File "plyvel\_plyvel.pyx", line 91, in plyvel._plyvel.raise_for_status
plyvel._plyvel.CorruptionError: b'Corruption: corrupted compressed block contents'

I testing, but can't reproduce error.

PS C:\Python36> ./python -m pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl
Collecting plyvel==1.1.0 from https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl
  Downloading https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl (200kB)
    100% |β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ| 204kB 29kB/s
Installing collected packages: plyvel
Successfully installed plyvel-1.1.0
You are using pip version 18.1, however version 19.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
PS C:\Python36> ./python -m pytest .\test_plyvel.py
============================================================================================= test session starts =============================================================================================
platform win32 -- Python 3.6.8, pytest-5.3.2, py-1.8.0, pluggy-0.13.1
rootdir: C:\Python36
collected 51 items

test_plyvel.py ...................................................                                                                                                                                       [100%]

============================================================================================= 51 passed in 2.18s ==============================================================================================
PS C:\Python36>
bwanaaa commented 4 years ago

Win10pro Anaconda latest Visual Studio 2019 community edition v16.4.6 Visual Studio Build Tools 2019 16.4.6

pip install plyvel

 plyvel/_plyvel.cpp(620): fatal error C1083: Cannot open include file: 'leveldb/db.h': No such file or directory
    error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.24.28314\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\Users\Stefan\Anaconda3\envs\TF\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"'; __file__='"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\Stefan\AppData\Local\Temp\pip-record-w3xpi6ee\install-record.txt' --single-version-externally-managed --compile Check the logs for full command output.

What is the recommended solution?

ppolxda commented 4 years ago

Win10pro Anaconda latest Visual Studio 2019 community edition v16.4.6 Visual Studio Build Tools 2019 16.4.6

pip install plyvel

 plyvel/_plyvel.cpp(620): fatal error C1083: Cannot open include file: 'leveldb/db.h': No such file or directory
    error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.24.28314\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\Users\Stefan\Anaconda3\envs\TF\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"'; __file__='"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\Stefan\AppData\Local\Temp\pip-record-w3xpi6ee\install-record.txt' --single-version-externally-managed --compile Check the logs for full command output.

What is the recommended solution?

you must include leveldb library. try to install vcpkg to build leveldb or use wheel package.

https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win

pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp37-cp37m-win_amd64.whl

bwanaaa commented 4 years ago

Running win10

(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp37-cp37m-win_amd64.whl
ERROR: plyvel-1.1.0-cp37-cp37m-win_amd64.whl is not a supported wheel on this platform.

this fails too

(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp35-cp35m-win_amd64.whl
ERROR: plyvel-1.1.0-cp35-cp35m-win_amd64.whl is not a supported wheel on this platform.

(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp38-cp38-win_amd64.whl
ERROR: plyvel-1.1.0-cp38-cp38-win_amd64.whl is not a supported wheel on this platform.
obsidianforensics commented 4 years ago

update new appveyor.yml. https://gist.github.com/ppolxda/1ebc6bdd2053984bc5ff7a799647bf75 windows wheel release https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win appveyor test build https://ci.appveyor.com/project/ppolxda/plyvel

Seems not work, I test with plyvel-1.1.0-cp36-cp36m-win_amd64.whl Error:

  File "plyvel\_plyvel.pyx", line 356, in plyvel._plyvel.DB.__iter__
  File "plyvel\_plyvel.pyx", line 362, in plyvel._plyvel.DB.iterator
  File "plyvel\_plyvel.pyx", line 788, in plyvel._plyvel.Iterator.__init__
  File "plyvel\_plyvel.pyx", line 91, in plyvel._plyvel.raise_for_status
plyvel._plyvel.CorruptionError: b'Corruption: corrupted compressed block contents'

I testing, but can't reproduce error.

PS C:\Python36> ./python -m pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl
Collecting plyvel==1.1.0 from https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl
  Downloading https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp36-cp36m-win_amd64.whl (200kB)
    100% |β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ| 204kB 29kB/s
Installing collected packages: plyvel
Successfully installed plyvel-1.1.0
You are using pip version 18.1, however version 19.3.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
PS C:\Python36> ./python -m pytest .\test_plyvel.py
============================================================================================= test session starts =============================================================================================
platform win32 -- Python 3.6.8, pytest-5.3.2, py-1.8.0, pluggy-0.13.1
rootdir: C:\Python36
collected 51 items

test_plyvel.py ...................................................                                                                                                                                       [100%]

============================================================================================= 51 passed in 2.18s ==============================================================================================
PS C:\Python36>

I'm having the same "plyvel._plyvel.CorruptionError: b'Corruption: corrupted compressed block contents'" error when using the provided wheel (on Win10x64, py37).

I've tried to build it myself using https://github.com/wbolster/plyvel/issues/60#issuecomment-487086860 after installing Snappy, but am getting Linker errors (and I really don't know what I'm doing). I've attached the leveldb that produced the error; would you mind taking a look and seeing if you can reproduce the CorruptionError with it? Thanks. leveldb-corruptionError.zip

AustEcon commented 4 years ago

pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp37-cp37m-win_amd64.whl

@ppolxda You are a bloody legend!! What a lifesaver providing those plyvel.whl's πŸ‘

josephernest commented 3 years ago

You're a lifesaver @AustEcon @ppolxda!

@wbolster Do you think it would possible to release this on PyPI such that pip install plyvel works easily on Windows, for Python 3.7, 3.8, 3.9, etc.?

wbolster commented 3 years ago

tbh i don't have the time, knowledge, nor interest to maintain anything windows related. builds on linux and osx already give/gave enough problems.

thinking also from a security perspective, i am not comfortable providing β€˜official’ packages that i cannot vet for. the linux binary wheels i can build in a fully isolated, deterministic and reproducible environment, which is why i upload those to pypi. for other operating systems, that is not the case.

AustEcon commented 3 years ago

You're a lifesaver @AustEcon @ppolxda!

@wbolster Do you think it would possible to release this on PyPI such that pip install plyvel works easily on Windows, for Python 3.7, 3.8, 3.9, etc.?

@josephernest I have this for windows as a workaround currently: https://github.com/AustEcon/plyvel-win32

https://pypi.org/project/plyvel-win32/

... use at your own risk... I only use it to run a local development server on windows and I think I have only done wheels for py37 and py38 iirc

but I can say that I have not had any issues with it over the past 6 months of regular use...

lifegpc commented 3 years ago

The new version of leveldb is works fine with MSVC. Just open Native Tools Command Prompt for VS 2019 Then

git clone https://github.com/google/leveldb --recursive
md build && cd build
cmake -G Ninja -DCMAKE_BUILD_TYPE=Release ../leveldb
ninja
ninja test
set "INCLUDE=%INCLUDE%;%CD%\..\leveldb\include"
set "LIB=%LIB%;%CD%"
pip install plyvel
chaosink commented 2 years ago

Thanks for @lifegpc! It works!

With PowerShell, use the following to set the environment variables.

$Env:INCLUDE="$PWD/include"
$Env:LIB="$PWD/build/Release"
Avnsx commented 2 years ago

Win10pro Anaconda latest Visual Studio 2019 community edition v16.4.6 Visual Studio Build Tools 2019 16.4.6 pip install plyvel

 plyvel/_plyvel.cpp(620): fatal error C1083: Cannot open include file: 'leveldb/db.h': No such file or directory
    error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.24.28314\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2
    ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\Users\Stefan\Anaconda3\envs\TF\python.exe' -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"'; __file__='"'"'C:\\Users\\Stefan\\AppData\\Local\\Temp\\pip-install-k6yh4h2t\\plyvel\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record 'C:\Users\Stefan\AppData\Local\Temp\pip-record-w3xpi6ee\install-record.txt' --single-version-externally-managed --compile Check the logs for full command output.

What is the recommended solution? you must include leveldb library. try to install vcpkg to build leveldb or use wheel package. https://github.com/ppolxda/plyvel/releases/tag/1.1.0.build-v0-win pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp37-cp37m-win_amd64.whl

Had the same issue as the other guy orginally and your provided solution doesn't work either, I just end up with the exact same as him:

Running win10

(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp37-cp37m-win_amd64.whl
ERROR: plyvel-1.1.0-cp37-cp37m-win_amd64.whl is not a supported wheel on this platform.

this fails too

(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp35-cp35m-win_amd64.whl
ERROR: plyvel-1.1.0-cp35-cp35m-win_amd64.whl is not a supported wheel on this platform.
(Db36) G:\Dropbox>pip install https://github.com/ppolxda/plyvel/releases/download/1.1.0.build-v0-win/plyvel-1.1.0-cp38-cp38-win_amd64.whl
ERROR: plyvel-1.1.0-cp38-cp38-win_amd64.whl is not a supported wheel on this platform.

@wbolster you got any way to fix this?

Python 3.8.10 for Windows 10, tried installing with pip and conda both fail

Edit: https://github.com/AustEcon/plyvel-wheels Works fine πŸ‘Œ

synodriver commented 2 years ago
git clone https://github.com/google/leveldb --recursive
md build && cd build
cmake   -G "Visual Studio 15 2017"   -A  x64 -DCMAKE_BUILD_TYPE=Release ../leveldb
cmake   --build . --config Release    
set LIB="{your absolute build path}\build\Release"   
set INCLUDE="{your absolute  leveldb repo path where you clone into}\include"
python -m pip install plyvel

It works for me. Hope github action could be used to build wheels for all platforms.

synodriver commented 2 years ago

For anyone who wants to install on windows, I've build a windows x64 version using github action which build against the main branch of leveldb.

Avnsx commented 2 years ago

For anyone who wants to install on windows, I've build a windows x64 version using github action which build against the main branch of leveldb.

If this windows built works it would be huge! I will check out soon

synodriver commented 2 years ago

For anyone who wants to install on windows, I've build a windows x64 version using github action which build against the main branch of leveldb.

If this windows built works it would be huge! I will check out soon

I've tested it on my pc(win10) and it works fine. Although I don't know why there are so many compiler warnings

Avnsx commented 2 years ago

Well @synodriver I did install and run it on python 3.10 and it works in terms of importing and basic stuff; but I still end up with the same error as explained here: https://github.com/wbolster/plyvel/issues/137

so @wbolster to get back to your comment https://github.com/wbolster/plyvel/issues/137#issuecomment-1002622117 I'm guessing this is a issue with your repo, since now that I could directly install your repos windows build provided by @synodriver and still ended up with the same issue ...

Avnsx commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in https://github.com/wbolster/plyvel/issues/137 @synodriver

synodriver commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in #137 @synodriver

You can check the warnings here. Basicly, the warnings occurs during compilation.

Avnsx commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in #137 @synodriver

You can check the warnings here. Basicly, the warnings occurs during compilation.

Can you access chromes local storage level db with your own windows build? or do u get the same issue as in my ticket?

synodriver commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in #137 @synodriver

You can check the warnings here. Basicly, the warnings occurs during compilation.

Can you access chromes local storage level db with your own windows build? or do u get the same issue as in my ticket?

I'm afraid I can't because I dont't use chrome.

lifegpc commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in #137 @synodriver

You can check the warnings here. Basicly, the warnings occurs during compilation.

Can you access chromes local storage level db with your own windows build? or do u get the same issue as in my ticket?

You need another library, snappy. I mean your leveldb library need linked with snappy.

Avnsx commented 2 years ago

I've tested it on my pc(win10) and it works fine. ~Although I don't know why there are so many compiler warnings~

Wait is there maybe any warning that could point to the decompression algorithm or whatever in plyvel to get broken; which would than cause my issue? in #137 @synodriver

You can check the warnings here. Basicly, the warnings occurs during compilation.

Can you access chromes local storage level db with your own windows build? or do u get the same issue as in my ticket?

I'm afraid I can't because I dont't use chrome.

It doesn't matter what browser you use pretty much all of them have leveldb storages in similar paths

synodriver commented 2 years ago

I hava no idea whether snappy is linked against leveldb during the compilation. It just able to compile.

lifegpc commented 2 years ago

image You can use dumpbin to see dependents if u use shared library.

Avnsx commented 2 years ago

I hava no idea whether snappy is linked against leveldb during the compilation. It just able to compile.

Your windows build is useless if it's not linked to snappy, because it most likely breaks every time there's a leveldb that uses compression (such as the leveldb that browsers create)

synodriver commented 2 years ago

I hava no idea whether snappy is linked against leveldb during the compilation. It just able to compile.

Your windows build is useless if it's not linked to snappy, because it most likely breaks every time there's a leveldb that uses compression (such as the leveldb that browsers create)

Would update the CI later to build against snappy. There are so many dependencies to compile against.

Avnsx commented 2 years ago

I hava no idea whether snappy is linked against leveldb during the compilation. It just able to compile.

Your windows build is useless if it's not linked to snappy, because it most likely breaks every time there's a leveldb that uses compression (such as the leveldb that browsers create)

Would update the CI later to build against snappy. ~There are so many dependencies to compile against.~

Please do regardless, I am waiting since Dec 21 for a working windows build 😭