wbolster / plyvel

Plyvel, a fast and feature-rich Python interface to LevelDB
https://plyvel.readthedocs.io/
Other
529 stars 75 forks source link

Remove reference to non-existent _static directory from Sphinx config #75

Closed sbraz closed 6 years ago

sbraz commented 6 years ago

Hi, This fixes the following error:

copying static files... WARNING: html_static_path entry '/tmp/plyvel/doc/_static' does not exist                                                                                                       
wbolster commented 6 years ago

thanks!

sbraz commented 6 years ago

@wbolster Weird, this is still present in the 1.0.5 tarball which is not the same as the 1.0.5 tag:

diff -ur ./doc/conf.py /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/doc/conf.py
--- ./doc/conf.py       2018-07-19 11:48:26.130204939 +0200
+++ /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/doc/conf.py      2018-01-06 22:48:56.000000000 +0100
@@ -23,6 +23,7 @@
 autodoc_default_flags = ['members', 'undoc-members']
 autodoc_member_order = 'bysource'

+html_static_path = ['_static']
 html_domain_indices = False
 html_show_sourcelink = False
 html_show_sphinx = False
diff -ur ./NEWS.rst /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/NEWS.rst
--- ./NEWS.rst  2018-07-19 11:48:26.130204939 +0200
+++ /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/NEWS.rst 2018-07-16 21:01:00.000000000 +0200
@@ -5,11 +5,10 @@
 Plyvel 1.0.5
 ============

-Release date: 2018-07-17
+Release date: 2018-07-16

 * Rebuild wheels: build against Snappy 1.1.7, and produce Python 3.7 wheels
-  (`issue #78 <https://github.com/wbolster/plyvel/issues/78>`_,
-  `pr #79 <https://github.com/wbolster/plyvel/pull/79>`_)
+  (`issue #78 <https://github.com/wbolster/plyvel/issues/78>`_)

 Plyvel 1.0.4
diff -ur ./setup.cfg /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/setup.cfg
--- ./setup.cfg 2018-06-18 13:00:29.132969178 +0200
+++ /var/tmp/portage/dev-python/plyvel-1.0.5/work/plyvel-1.0.5/setup.cfg        2018-07-17 11:37:04.000000000 +0200
@@ -4,3 +4,8 @@

 [tool:pytest]
 addopts = -sv
+
+[egg_info]
+tag_build = 
+tag_date = 0
+
wbolster commented 6 years ago

yeah i noticed :(

i did all the work locally, made tarballs and so on, then tried to push, only to notice my local master was missing that commit (i forgot to fetch). i rebased, pushed, tagged, but didn't bother to rebuild all the binary artefacts.

don't think this is a problem for anyone though?

wbolster commented 6 years ago

actually hoped noone would notice heh

sbraz commented 6 years ago

actually hoped noone would notice heh

:smile:

don't think this is a problem for anyone though?

Nah it's no big deal, don't worry. If you want to save yourself all the trouble for future releases, you could look into using Travis to deploy every time you tag a commit. I also use setuptools_scm to avoid having to change the version string manually.

wbolster commented 6 years ago

yeah, i know it can do that and it would be better. but making travis also build manylinux1 wheels and upload those automatically requires more setup, and i just haven't invested in that.