wbolster / plyvel

Plyvel, a fast and feature-rich Python interface to LevelDB
https://plyvel.readthedocs.io/
Other
529 stars 75 forks source link

Add py37 to tox.ini #79

Closed hairychris closed 5 years ago

hairychris commented 6 years ago

Blocked by https://github.com/travis-ci/travis-ci/issues/9815 as Travis doesn't currently support Python 3.7 and 3.4 simultaneously.

carver commented 6 years ago

From the travis issue:

So for now the best thing to do is to have sudo: required just for job with 3.7.0.

Maybe this workaround could get us there without waiting ^ ?

wbolster commented 6 years ago

this is not blocking anything. plyvel works with python 3.7 already, and you can pip install it already today. the only thing missing is linux wheels for 3.7

hairychris commented 6 years ago

Sorry I presumed making sure the build works was a requirement to getting these wheels released.

carver commented 6 years ago

this is not blocking anything ... the only thing missing is linux wheels for 3.7

Cool, is there anything blocking the release of the linux wheels?


@hairychris The Travis thread implies that dist: xenial might also be required

wbolster commented 6 years ago

no blockers anymore except some maintainer time and effort. :)

i tried to update libsnappy (embedded in the wheels) to the latest upstream release but ran into some complications... the build system changed to cmake which just requires a few different commands, but cmake is not available by default inside the build environment (docker container).

i fixed all of the above already, and just need to find a bit of time to round it up, make new builds and publish those on pypi.

feel free to kindly remind me in a few days if i haven't gotten around to it by then.

carver commented 6 years ago

Thanks wbolster!

@hairychris ah, and now 3.4 is busted, which people in that thread experienced too. That's why the final line was (my emphasis):

So for now the best thing to do is to have sudo: required just for job with 3.7.0.

hairychris commented 6 years ago

Yeah I thought that might happen but worth checking, I don't really want to change too much to get around a temporary issue.

wbolster commented 6 years ago

i published plyvel 1.0.5 with python 3.7 wheels on pypi. https://plyvel.readthedocs.io/en/latest/news.html

wbolster commented 6 years ago

i pushed the tox.ini changes in fbfaecdd07126fa7a113a96b6c27ac7099510b42

let's wait for travis to settle before introducing hacks that will quickly turn into technical debt when travis sorts out their infra.

wbolster commented 6 years ago

for those interested: 20d1d2c2ffb43774d415d92d9f80726fb1d5859d contains the build changes i referred to earlier

wbolster commented 5 years ago

closing, see #102