search

wbolster / plyvel

Plyvel, a fast and feature-rich Python interface to LevelDB
https://plyvel.readthedocs.io/
Other
529 stars 75 forks source link

Fix OSX Build issue #97

Closed schmty closed 5 years ago

schmty commented 5 years ago

Okay here goes again: Via adding the extra compile arguments of -x c++ -std=c++11 and removing platform specific code as suggested by @kyuupichan and @wbolster in #95 plyvel now builds on OSX 10.14. This PR should fix #95 I'm using OSX 10.14 and make and make test are both working on my system using python 3.7.3

schmty commented 5 years ago

I realized that the reason travis was returning failing builds was due to a version conflict it was having installing pytest Specifying pytest>=3.6 makes the travis builds pass

wbolster commented 5 years ago

thanks!