search

wbond / ChannelRepositoryTools

A Sublime Text package for working with channels and repositories
https://packagecontrol.io/packages/ChannelRepositoryTools
MIT License
12 stars 4 forks source link

Updates #4

Closed evandrocoan closed 5 years ago

evandrocoan commented 5 years ago

How did you do this bullet comments with commit links and messages?

  • 171e314: Added missing LICENSE This is unnecessary when there is a file named license in the repo.

Now there is a link there too.

  • 9163838: _Set to recursively search for the package_controlchannel directory I don't exactly see a practical use for this either. Just add the directory to your folders when you want to run the tests. Going through an arbitrarily deeply nested folder structure will only increase the surface for errors, e.g. unprecedented runtime. (Also, you'd actually want to check dirs in the loop.)

It is working. By default, it only finds your this repository if it is on the top level. I added this because I have it nested deep inside an bigger project.

  • ~e8d3af8: Created a .no-sublime-package for all packages, in attempt to fix~
  • ~a6f2750: Revert "Created a .no-sublime-package for all packages, in attempt to…~
  • 315c266: Set to run the tests command on a background thread ec4a0da: Set to show a message warning when running commands d633a36: Removed duplicate function code d2fd3d9: Replaced duplicated try...finally by decorator I grouped the above, since they are related (and should probably be squashed).

I Squashed them.

Adding a mutex to the running commands is a good idea, although I'd instead add a decorator around the entire run method since their structure is almost identical. Furthermore, I'd use an actual global boolean instead of a faux static class, because that's essentially what it's used as. Always prefer the more direct approach.

I added a lock and a super decorator.

  • 49f1a17: Set to show the output results on output.exec panel The exec panel is for the exec command. We shouldn't be re-using it, even though we are showing "output". It's out own output after all.

I added a setting to name the panel you would like.

FichteFoll commented 5 years ago

How did you do this bullet comments with commit links and messages?

I just copied the commit hashes and commit messages from this page and modified them with multiple selections in ST. Github automatically creates links for 7+-digit hashes in text.

It is working. By default, it only finds your this repository if it is on the top level. I added this because I have it nested deep inside an bigger project.

I didn't say it wasn't. It's up to you if you prefer a deeply nested project, but you need to consider the average user and their use case, which is most certainly not doing what you do and then you get all the downsides I mentioned earlier. This is a case of over-engineering.

I added a setting to name the panel you would like.

As is this. Nobody (besides you, maybe?) will ever use this. I guarantee that.

Good work on the lock.

evandrocoan commented 5 years ago

Thanks for reviewing the code!

I just copied the commit hashes and commit messages from this page and modified them with multiple selections in ST. Github automatically creates links for 7+-digit hashes in text.

Nice!

average user and their use case, which is most certainly not doing what you do and then you get all the downsides I mentioned earlier.

Well, I just added a setting default to disabled. Then, now they will only have an overhead if they enable it.

Nobody (besides you, maybe?) will ever use this.

Nooo way. From 7 billion of people, I cannot be the only one insane like that!