search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.79k stars 814 forks source link

Urllib downloader doesn't handle HTTP 302 redirects #1503

Closed sunnyps closed 1 year ago

sunnyps commented 3 years ago

Some HTTP proxies will respond to requests with 302 redirects, and it seems Package Control's urllib downloader doesn't handle those.

By default urllib uses an HTTPRedirectHandler instance to handle redirects, but it's missing from the list of handlers in urllib_downloader.py setup_opener: https://github.com/wbond/package_control/blob/b9de5ffa545364f05cb94078b0f8b976d67a77f2/package_control/downloaders/urllib_downloader.py#L257

Package Control.sublime-settings.txt

package_control.log

sunnyps commented 3 years ago

Just noticed that #1502 is essentially the same issue, so feel free to close this.