search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.79k stars 814 forks source link

Replace Travis by GitHub workflows #1521

Closed deathaxe closed 3 years ago

deathaxe commented 3 years ago

It appears travis-ci.org is closing in some weeks.

Maybe a good point to switch to github actions for linting pull requests.

deathaxe commented 3 years ago

flake8 fails on unused but assigned variables in the new dependency.py module.

I am also a bit curios why lintly doesn't add comments here. I tested it at https://github.com/deathaxe/package_control/pull/1.

FichteFoll commented 3 years ago

I suspect that workflow pull request involving the secrets context must be on the master branch before they are active.

I've also had success with https://github.com/rbialon/flake8-annotations, just as another example, which does not create comments inside the PR, however.

wbond commented 3 years ago

I appreciate you trying to fix things, but can you explain why you removed the ability for me to installing linting tools and run the linter for Python 3.3?

wbond commented 3 years ago

flake8 fails on unused but assigned variables in the new dependency.py module.

This is known. I pushed up some WIP and wanted to leave those there because there is the intention they will be used.

deathaxe commented 3 years ago

This is known. I pushed up some WIP

Sure, just wanted to note it to explain failing tests.

deathaxe commented 3 years ago

If all of that is too much more than handling a git workflow It is not for me. Means the experience I have with those workflow tools is not enough to provide useful input.

wbond commented 3 years ago

No worries, I appreciate you trying to help. It sounds like lintly may be useful to add to a 3.8 run.

I'll whip up a PR since I've (unfortunately) had way too much experience with the "joy" of CI on Python projects.

deathaxe commented 3 years ago

World needs more efficent solutions to share minds. :-D

Those topics just start to get a need for my part of software development and I try to get some useful entry to all of that.

I just got aware of python 3.3 to be needed offline, too, in order to ensure not to break something.