search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.78k stars 814 forks source link

Fix cli_downloader on Windows #1539

Closed deathaxe closed 3 years ago

deathaxe commented 3 years ago

This PR enables usage of cli_downloader on Windows OS by fixing 2 issues.

First of them prevented curl.exe or wget.exe from being found by find_binary() method as it missed to add the file extension.

Second fix addresses an issue with console window being displayed if an executable is invoked, which caused bad user experience.

curl.exe is shipped by default as of Windows 10 and therefore might be used as downloader. May be quite uncommon as the others do a good job, but if someone decides to use it, it should work.

rwols commented 3 years ago

These downloaders are core to Package Control, can't we build some integration tests around these things?

EDIT: off-topic I know

deathaxe commented 3 years ago

You want something like that: https://github.com/deathaxe/package_control/blob/next/package_control/tests/downloaders.py?

wbond commented 3 years ago

I don't really have the intention of trying to support curl or wget on Windows, but if someone wants to configure them, I am fine with that.