search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.79k stars 816 forks source link

Manually git-cloned deps are not accounted for in four-point-oh branch #1550

Closed rwols closed 1 year ago

rwols commented 3 years ago

I have https://github.com/sublimelsp/lsp_utils checked out via git in $packages but it's not getting migrated:

Package Control: Error loading dependency metadata during migration - [Errno 2] No such file or directory: '/Users/raoulwols/Library/Application Support/Sublime Text 3/Packages/lsp_utils/dependency-metadata.json'
rwols commented 3 years ago

Maybe the question is should we also migrate these types of folders. Or let the users take care of these cases themselves.

deathaxe commented 3 years ago

The bootstrapper needs the dependencies-metadata.json to successfully create the libraries meta-info so that it looks as the dependency was installed via pip. Not sure if we should try to migrate a repository as it can't be moved completely anyway. The other question was, which version info to use then.

Even though later on, you won't be able to git clone a dependency repo into the libs folder directly anyway. Means some more work is needed to handle such cloned deps. So tryiing to migrate them somehow might not be a good idea. It would leave the repo in the $packages path, which is probably not what we want.