wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.78k stars 814 forks source link

Fix migration error when a src dir already exists #1551

Closed rwols closed 3 years ago

rwols commented 3 years ago

close #1549

deathaxe commented 3 years ago

I guess this issue will be resolved once new dependencies are installed into libs directly. Fixing it at this point might cause all deps to be migrated at each startup, which is probably not what we want.

rwols commented 3 years ago

Fixing it at this point might cause all deps to be migrated at each startup, which is probably not what we want.

That's what I was wondering about. Why is PC still running the migrate code once "bootstrapped" is set to 4 in Packages/User/Package Control.sublime-settings?

deathaxe commented 3 years ago

Because it just checks for existence of 0_package_control_loader package, which is re-created as soon as dependencies are updated. You can't expect perfect behavior at this point. It's a WIP branch. 😄

rwols commented 3 years ago

OK, it sounds like there was some thought put into this at least.