search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.78k stars 814 forks source link

Update dependencies on doing the update check #1561

Closed rchl closed 1 year ago

rchl commented 3 years ago

The dependencies were not updated on running the update check. They were only updated if some package that depended on them was being updated but that is not sufficient.

Note that I haven't tested this change on four-point-oh branch because that branch is not functional at the current time. I've tested on master though and the relevant code looks the same and the fix applies cleanly to both so I'm assuming it should work as well.

As this appears to be quite a high-level code, it possibly won't even be affected (broken) during a rewrite of the dependency handling.

FichteFoll commented 3 years ago

I can't really comment on the overall logic here because I'm totally not into the code base.

rchl commented 1 year ago

@FichteFoll I suppose there are no really any changes you require me to do so you could change the approval state to not make it seem like there is more for me to do here.

rchl commented 1 year ago

Is this still relevant for the 4.0 branch or should I just close it?

deathaxe commented 1 year ago

Installing or updating a package triggers install/update of all used dependencies/libraries. So this PR is probably no longer required.

rchl commented 1 year ago

That's not the case that was being fixed here. Check my initial message. The case that was being fixed was when a new version of dependency was released, without new version of package using it being released.

deathaxe commented 1 year ago

Libraries are not yet updated independently, but your implementation wouldn't work at all anymore as they are no longer handled as a kind of package.

I guess I kept this open as reminder. An issue would be enough though.

deathaxe commented 1 year ago

6da06bc2ff0efe2f6e3b9b3bb5387951353e411c adds support to automatically upgrade libraries/dependencies.

Package Control: Satisfy Libraries installs missing, upgrades outdated and removes orphaned libraries as it did before.

rchl commented 1 year ago

Are you sure that code will update outdated dependencies? Based on the naming of called methods I would think it will only install missing dependencies. So if that's not the case then maybe the method names are not ideal.

deathaxe commented 1 year ago

required - missing = installed and maybe outdated