search

wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.78k stars 814 forks source link

fix: HTML decoding error in QuickPanelItem #1580

Closed jfcherng closed 1 year ago

jfcherng commented 3 years ago

There are some special chars in the URL.

Reproduction Steps

  1. Open command palette
  2. Run Package Control: Install Package
  3. Type autos for filtering
  4. Check your console

image

Env

PC: 3.4.1 ST: 4113 Win64

deathaxe commented 3 years ago 
view.show_popup("<a href=\"http://www.sublimetext.com/forum/viewtopic.php?f=5&t=2607\">test</a>")

... results in same output. It's the equal sign in t=2607 which ST's minihtml API doesn't like.

Looks more like a core bug, then something Package Control could work around.

Nevermind, I'm blind!

I was under the expression this to be an issue.

But it's somewhat strange anyway, those href part to require html encoding of & to &amp; to work properly.

deathaxe commented 1 year ago

Added a relevant fix to four-point-oh. Closing this as superseeded as PC3.x won't receive any fixes anymore.