wbond / package_control

The Sublime Text package manager
https://packagecontrol.io
4.77k stars 816 forks source link

#1663 Fix python 3.8 dependencies being overwritten by 3.3 #1664

Closed evandrocoan closed 5 months ago

evandrocoan commented 5 months ago

Fix #1663

When a dependency sets 'python_versions', it is overwritten by 3.3 only.

deathaxe commented 5 months ago

The changed code path is for decoding repositories of schema version 1.2 to 3.0.0, which do not support python_versions keys. It rather migrates those to schema 4.0.0 by adding a default value.

A channel.json of schema_version: 4.0.0 is required to support python 3.8 libraries.

packagecontrol.io still ships 3.0.0

evandrocoan commented 5 months ago

Is there a specification for schema 4.0.0 somewhere?

evandrocoan commented 5 months ago

Thanks for the explanation on the other issue. https://github.com/wbond/package_control/issues/1663#issuecomment-1924446083

I see this looks like an example of channel 4.0 schema you provided: https://github.com/packagecontrol/channel/blob/02bc2b4cd1f9739f203b9e3003fefca39e8d2a9c/repository.json

That example should be enough for me to upgrade my schema generation. I am just curious if there is a schema specification or if I should base myself on your schema 4.0 example?

deathaxe commented 5 months ago

Package Control ships json schemas for schemes, to provide completions via LSP an LSP-json as well as linting/validation.

A bare bone repository or channel can be created via command palette.

There are no plans for detailed specification papers.