wbond / packagecontrol.io

The Package Control website
https://packagecontrol.io
Other
111 stars 46 forks source link

Changed .context display to inline-block from block #30

Closed MattDMo closed 9 years ago

MattDMo commented 10 years ago

Hi Will, When on a package page (for example, https://sublime.wbond.net/packages/R-Box), just above the package's name is a BROWSE link, with class context. It has the property display: block, which means that the hyperlink area extends all the way across the main div, not just the word BROWSE. If a user were to randomly click just below the search box, for example, they'd go to https://sublime.wbond.net/browse, which IMO is unexpected behavior. I edited /app/css/layout.scss and /public/css/app.css from

a.context, span.context {
    color: #999;
    display: block;
    font-family: 'Open Sans', Helvetica, Arial, Verdana, sans-serif;
    font-size: 1.4em;
    line-height: 1.2;
    margin-left: 0;
    text-transform: uppercase
}

to

a.context, span.context {
    color: #999;
    display: inline-block; /* <-- */
    font-family: 'Open Sans', Helvetica, Arial, Verdana, sans-serif;
    font-size: 1.4em;
    line-height: 1.2;
    margin-left: 0;
    text-transform: uppercase
}

This changes the link area from stretching all the way across the div to just the text. I searched through all the code, and couldn't find any templates where this would result in different behavior than that described above, so this should be a pretty safe change.

Please let me know if you need anything else.

Thanks, Matt