search

wbond / packagecontrol.io

The Package Control website
https://packagecontrol.io
Other
111 stars 46 forks source link

adding tabindex to logo and search field #72

Open jamiewilson opened 8 years ago

jamiewilson commented 8 years ago

First tab to search, second tab to logo/home link, third to next anchor, currently first link in the nav

wbond commented 8 years ago

Thanks for taking the time to suggest from improvements!

The opacity transition is currently being used (https://github.com/wbond/packagecontrol.io/blob/master/app/css/package.scss#L7-L13). Try navigating from a package detail page to the homepage. Also try hovering over the logo on a package detail page.

Setting the tab index should be good.

Generally I'm not a huge fan of overriding the outline, but I haven't looked to see how this specific example functions.

jamiewilson commented 8 years ago

Cool. Thanks for pointing that out. Somehow I missed that opacity usage!

I just removed the styling, so feel free to merge this for the tabindex additions, but if it's easier to add them yourself, no worries. Just one of those things I always find myself doing when I come to search.