Travis CI Config for Python 3

wbond / pybars3

Handlebars.js template support for Python 3 and 2

GNU Lesser General Public License v3.0

179 stars 46 forks source link

Travis CI Config for Python 3 #39

Closed wbond closed 7 years ago

wbond commented 7 years ago

The whole point of this library versus pybars is to support Python 3. The Travis CI config should probably run this on at least Python 3.3 and 2.7 because of that.

maxkoryukov commented 7 years ago

Absolutely... I tried to build pybars3 with different python versions, and there are several different issues. Here is a link to my build: https://travis-ci.org/maxkoryukov/pybars3/builds/184107757

flake8

./pybars/_compiler.py:185:25: F821 undefined name 'unicode'
./pybars/_compiler.py:271:16: F821 undefined name 'unicode'
2     F821 undefined name 'unicode'

tests / coverage

The code doesn't pass all tests, in most cases I got:

AttributeError: 'PybarsError' object has no attribute 'message'

maxkoryukov commented 7 years ago

FYI: I have a branch for this issue, I think, I could fix this on this week

wbond commented 7 years ago

Rather than e.message you should be casting the error to str.

maxkoryukov commented 7 years ago

it is your test code ;))

anyway: e.message => str(e) DONE

python 2.6 - fucked up.. users with python 2.6 should upgrade their soft
python 3.2 - doesn't know what to do with u'some string'. I think, we could drop this version too;)